nickpons666/Shiip-of-Hakinian-Espanol
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

clean up comments (#6369)

Browse Source
This commit is contained in:
Philip Dubé
2026-03-18 01:27:08 +00:00
committed by GitHub
parent e7dce8e055
commit 97eaa8b3e0
6 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
soh/soh/Enhancements/cosmetics/authenticGfxPatches.cpp
View File

@@ -283,8 +283,8 @@ void PatchIronKnuckleTextureOverflow() {
void PatchBoulderFragment() { void PatchBoulderFragment() {
// The boulder fragment renders invisible due to the change made by https://github.com/Kenix3/libultraship/pull/721 // The boulder fragment renders invisible due to the change made by https://github.com/Kenix3/libultraship/pull/721
// Until it is known wether this change is approriate or something else should be done to it, the following patches // Until it is known whether this change is appropriate or something else should be done to it, the following
// adjust the render mode for the DL to not become invisible // patches adjust the render mode for the DL to not become invisible
ResourceMgr_PatchGfxByName(gBoulderFragmentsDL, "boulderFragmentRenderFix3", 3, ResourceMgr_PatchGfxByName(gBoulderFragmentsDL, "boulderFragmentRenderFix3", 3,
gsDPSetRenderMode(G_RM_FOG_SHADE_A, G_RM_AA_ZB_OPA_SURF2)); gsDPSetRenderMode(G_RM_FOG_SHADE_A, G_RM_AA_ZB_OPA_SURF2));
ResourceMgr_PatchGfxByName(gBoulderFragmentsDL, "boulderFragmentRenderFix6", 6, ResourceMgr_PatchGfxByName(gBoulderFragmentsDL, "boulderFragmentRenderFix6", 6,

2
soh/soh/Enhancements/randomizer/draw.cpp
View File

@@ -418,7 +418,7 @@ extern "C" void Randomizer_DrawTriforcePiece(PlayState* play, GetItemEntry getIt
CLOSE_DISPS(play->state.gfxCtx); CLOSE_DISPS(play->state.gfxCtx);
} }
// Seperate draw function for drawing the Triforce piece when in the GI state. // Separate draw function for drawing the Triforce piece when in the GI state.
// Needed for delaying showing the triforce piece slightly so the triforce shard doesn't // Needed for delaying showing the triforce piece slightly so the triforce shard doesn't
// suddenly snap to the new piece model or completed triforce because the piece is // suddenly snap to the new piece model or completed triforce because the piece is
// given mid textbox. Also makes it so the overworld models don't turn into the completed // given mid textbox. Also makes it so the overworld models don't turn into the completed

2
soh/soh/Enhancements/randomizer/randomizer.cpp
View File

@@ -422,7 +422,7 @@ ItemObtainability Randomizer::GetItemObtainabilityFromRandomizerGet(RandomizerGe
return OTRGlobals::Instance->gRandoContext->GetOption(RSK_BOMBCHU_BAG).Is(RO_BOMBCHU_BAG_NONE) return OTRGlobals::Instance->gRandoContext->GetOption(RSK_BOMBCHU_BAG).Is(RO_BOMBCHU_BAG_NONE)
? CAN_OBTAIN ? CAN_OBTAIN
: (INV_CONTENT(ITEM_BOMBCHU) != ITEM_NONE ? CAN_OBTAIN : CANT_OBTAIN_NEED_UPGRADE); : (INV_CONTENT(ITEM_BOMBCHU) != ITEM_NONE ? CAN_OBTAIN : CANT_OBTAIN_NEED_UPGRADE);
case RG_PROGRESSIVE_BOMBCHU_BAG: // RANDOTODO Do we want bombchu refills to exist separatly from bombchu bags? case RG_PROGRESSIVE_BOMBCHU_BAG: // RANDOTODO Do we want bombchu refills to exist separately from bombchu bags?
// If so, this needs changing. // If so, this needs changing.
switch (OTRGlobals::Instance->gRandoContext->GetOption(RSK_BOMBCHU_BAG).Get()) { switch (OTRGlobals::Instance->gRandoContext->GetOption(RSK_BOMBCHU_BAG).Get()) {
case RO_BOMBCHU_BAG_NONE: case RO_BOMBCHU_BAG_NONE:

1
soh/soh/Enhancements/randomizer/randomizerTypes.h
View File

@@ -44,7 +44,6 @@ typedef struct ShopItemIdentity {
int32_t itemPrice; int32_t itemPrice;
} ShopItemIdentity; } ShopItemIdentity;
// RANDOTODO compare child long jumpslash range with adult short
#define ENTRANCE_GROTTO_LOAD_START 0x0700 #define ENTRANCE_GROTTO_LOAD_START 0x0700
#define ENTRANCE_GROTTO_EXIT_START 0x0800 #define ENTRANCE_GROTTO_EXIT_START 0x0800

2
soh/soh/Enhancements/randomizer/settings.cpp
View File

@@ -3430,7 +3430,7 @@ void Settings::ParseJson(nlohmann::json spoilerFileJson) {
nlohmann::json settingsJson = spoilerFileJson["settings"]; nlohmann::json settingsJson = spoilerFileJson["settings"];
for (auto it = settingsJson.begin(); it != settingsJson.end(); ++it) { for (auto it = settingsJson.begin(); it != settingsJson.end(); ++it) {
// todo load into cvars for UI // todo load into cvars for UI
// RANDOTODO handle numeric value to options conversion better than brute froce // RANDOTODO handle numeric value to options conversion better than brute force
if (StaticData::optionNameToEnum.contains(it.key())) { if (StaticData::optionNameToEnum.contains(it.key())) {
const RandomizerSettingKey index = StaticData::optionNameToEnum[it.key()]; const RandomizerSettingKey index = StaticData::optionNameToEnum[it.key()];
mContext->GetOption(index).Set(mOptions[index].GetValueFromText(it.value())); mContext->GetOption(index).Set(mOptions[index].GetValueFromText(it.value()));

2
soh/soh/ResourceManagerHelpers.cpp
View File

@@ -543,7 +543,7 @@ extern "C" SkeletonHeader* ResourceMgr_LoadSkeletonByName(const char* path, Skel
} }
// This function is only called when a skeleton is initialized. // This function is only called when a skeleton is initialized.
// Therefore we can take this oppurtunity to take note of the Skeleton that is created... // Therefore we can take this opportunity to take note of the Skeleton that is created...
if (skelAnime != nullptr) { if (skelAnime != nullptr) {
auto stringPath = std::string(path); auto stringPath = std::string(path);
SOH::SkeletonPatcher::RegisterSkeleton(stringPath, skelAnime); SOH::SkeletonPatcher::RegisterSkeleton(stringPath, skelAnime);