From 8f51dfbaf45c17886e40b30222fb52d3282551e2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Philip=20Dub=C3=A9?= Date: Thu, 19 Mar 2026 18:24:25 +0000 Subject: [PATCH] Item Tracker: don't disable Personal Notes (#6376) Personal Notes is awkward with Combo Button Hold, but should be allowed This avoids disabling drop down when it could otherwise be changed to Main Window Besides, some people might be able to type while holding button combos, long live artsey.io --- .../randomizer/randomizer_item_tracker.cpp | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/soh/soh/Enhancements/randomizer/randomizer_item_tracker.cpp b/soh/soh/Enhancements/randomizer/randomizer_item_tracker.cpp index c95394eee..c2d6cf3be 100644 --- a/soh/soh/Enhancements/randomizer/randomizer_item_tracker.cpp +++ b/soh/soh/Enhancements/randomizer/randomizer_item_tracker.cpp @@ -25,9 +25,6 @@ extern "C" { #include "functions.h" #include "macros.h" extern PlayState* gPlayState; - -#include "textures/icon_item_static/icon_item_static.h" -#include "textures/icon_item_24_static/icon_item_24_static.h" } void DrawEquip(ItemTrackerItem item); @@ -2380,14 +2377,6 @@ void RegisterItemTrackerWidgets() { .LabelPosition(LabelPositions::Far) .Color(THEME_COLOR) .ComboMap(displayTypes)) - .PreFunc([&](WidgetInfo& info) { - if (CVarGetInteger(CVAR_TRACKER_ITEM("WindowType"), TRACKER_WINDOW_FLOATING) == TRACKER_WINDOW_FLOATING && - CVarGetInteger(CVAR_TRACKER_ITEM("DisplayType.Main"), TRACKER_DISPLAY_ALWAYS) == - TRACKER_DISPLAY_COMBO_BUTTON) { - info.options.get()->disabled = true; - info.options.get()->disabledTooltip = notesDisabledTooltip; - } - }) .Callback([](WidgetInfo& info) { shouldUpdateVectors = true; }); ; SohGui::mSohMenu->AddSearchWidget({ personalNotesWiget, "Randomizer", "Item Tracker", "General Settings" });