From 5cac826f97525a7de8b2d7ef8913d560ca50183e Mon Sep 17 00:00:00 2001 From: Pepe20129 <72659707+Pepe20129@users.noreply.github.com> Date: Fri, 3 Oct 2025 00:45:58 +0200 Subject: [PATCH] Add a warning for disabled network (#5629) * Update SohMenu.cpp * clang * Prevent warning from appearing in release builds --- soh/soh/SohGui/SohMenu.cpp | 23 +++++++++++++++++++++-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/soh/soh/SohGui/SohMenu.cpp b/soh/soh/SohGui/SohMenu.cpp index d5c2c0c1f..547025391 100644 --- a/soh/soh/SohGui/SohMenu.cpp +++ b/soh/soh/SohGui/SohMenu.cpp @@ -81,14 +81,33 @@ SohMenu::SohMenu(const std::string& consoleVariable, const std::string& name) : Menu(consoleVariable, name, 0, UIWidgets::Colors::LightBlue) { } +#ifndef ENABLE_REMOTE_CONTROL +void SohMenu::AddMenuNetwork() { +#ifndef _DEBUG + // in release builds, the tab doesn't even show + return; +#endif + + // Add Network Menu + AddMenuEntry("Network", CVAR_SETTING("Menu.NetworkSidebarSection")); + + WidgetPath path = { "Network", "Info", SECTION_COLUMN_1 }; + AddSidebarEntry("Network", path.sidebarName, 2); + + AddWidget(path, + ICON_FA_EXCLAMATION_TRIANGLE " The Network features are unavailable because SoH was compiled without " + "network support (\"ENABLE_REMOTE_CONTROL\" build flag).", + WIDGET_TEXT) + .Options(TextOptions().Color(Colors::Orange)); +} +#endif + void SohMenu::InitElement() { Ship::Menu::InitElement(); AddMenuSettings(); AddMenuEnhancements(); AddMenuRandomizer(); -#ifdef ENABLE_REMOTE_CONTROL AddMenuNetwork(); -#endif AddMenuDevTools(); if (CVarGetInteger(CVAR_SETTING("Menu.SidebarSearch"), 0)) {